Image Proxy refresh seems inefficient

  • Thread starter Thread starter Kirby
  • Start date Start date

Kirby

Guest
Member
When refreshing a proxied image, XF\Service\ImageProxy::finalizeFromFetchResults() always does write the image file on success even if nothing has changed.

This does seem inefficient as it does cause more writes than necessary which could be an issue when using short refresh times and SSDs.

The file should therefore only be written if the data actually has changed, ideally by using a hash stored in the DB.
 
Top